Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improper use of mask in HorneExtract #167

Open
cshanahan1 opened this issue Apr 5, 2023 · 3 comments
Open

Improper use of mask in HorneExtract #167

cshanahan1 opened this issue Apr 5, 2023 · 3 comments

Comments

@cshanahan1
Copy link
Contributor

A user may (optionally) provide a mask along with their data to HorneExtract. Any NaNs in the image are added also to this mask (or used to create one, if one wasn't provided). If the dispersion axis is X, and there are ANY masked pixels in that column even outside of the trace, that column will not be fit.

I've attached some images below to demonstrate the issue. I created a flat spectrum with a gaussian profile, masked a single pixel in a subset of columns, and the extracted spectrum shows no values in those columns with masked pixels were fit. The mask wasn't being used to omit pixels from the fit, it is used to discard entire rows/columns.
@cshanahan1
Copy link
Contributor Author

Screen Shot 2023-04-05 at 1 11 37 PM

@cshanahan1
Copy link
Contributor Author

Screen Shot 2023-04-05 at 1 15 49 PM

@cshanahan1
Copy link
Contributor Author

Screen Shot 2023-04-05 at 1 12 18 PM

@cshanahan1 cshanahan1 mentioned this issue Oct 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cshanahan1