Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BasicPSFPhotometry does not have an init_guesses keyword #970

Closed
astrofrog opened this issue Oct 18, 2019 · 4 comments
Closed

BasicPSFPhotometry does not have an init_guesses keyword #970

astrofrog opened this issue Oct 18, 2019 · 4 comments
Labels

Comments

@astrofrog
Copy link
Member

astrofrog commented Oct 18, 2019

The documentation at:

https://photutils.readthedocs.io/en/stable/api/photutils.psf.BasicPSFPhotometry.html#photutils.psf.BasicPSFPhotometry

refers to init_guesses but it doesn't seem to be a valid keyword argument.

If this was removed, what is now the proper way to provide the list of positions if these have already been determined beforehand?

@astrofrog
Copy link
Member Author

My bad it's an argument to do_photometry and __call__ - however I think in the docstring when this is mentioned:

If finder is None, initial guesses for positions of objects must be provided

it would be good to specify how. Also later when it's mentioned that init_guesses is an argument to do_photometry, it would be good to specify __call__ as well?

@astrofrog
Copy link
Member Author

On a related note, the intersphinx link is broken for init_guesses:

Screenshot from 2019-10-18 13-19-04

@astrofrog
Copy link
Member Author

On a somewhat related note, it would be good if init_guesses could be smart about the names for the x/y columns (in a similar vein to #966). It's difficult to have to always make new tables with different names :-/

@larrybradley
Copy link
Member

The init_params table is now very flexible in the allowed x/y column names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants