Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autocorrelation pair count normalization #974

Open
aphearin opened this issue Jan 7, 2020 · 0 comments
Open

autocorrelation pair count normalization #974

aphearin opened this issue Jan 7, 2020 · 0 comments
Assignees
Milestone

Comments

@aphearin
Copy link
Contributor

aphearin commented Jan 7, 2020

As pointed out by @Christopher-Bradshaw in #962 (and also manodeep/Corrfunc#201), the angular_tpcf function appears to have an incorrect factor of Nr x Nr instead of Nr x (Nr-1). This has a negligible impact on all practical cases of interest, but the error is needless and should still be fixed. The main question concerns whether other mock_observables functions are impacted as well, or whether this is isolated to angular_tpcf.

@aphearin aphearin added this to the v0.7 milestone Jan 7, 2020
@aphearin aphearin self-assigned this Jan 7, 2020
@aphearin aphearin modified the milestones: v0.7, next-release Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant