Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-essential sim_manager features from halotools #958

Open
aphearin opened this issue Oct 28, 2019 · 0 comments
Open

Remove non-essential sim_manager features from halotools #958

aphearin opened this issue Oct 28, 2019 · 0 comments

Comments

@aphearin
Copy link
Contributor

Currently, there is a lot of functionality in sim_manager that is a pain to maintain. So in v0.7, some of this will be migrated to a separate "convenience package" that is not part of halotools.

The following list summarizes the features that I'm proposing will remain in Halotools:

  • TabularAsciiReader
  • UserSuppliedHaloCatalog
  • UserSuppliedPtclCatalog

The following list summarizes the features that I'm proposing will be removed from Halotools:

  • CachedHaloCatalog - This means that it will no longer be possible to use halotools to load a simulation from its nickname. Instead, Halotools will just implement a barebones read using h5py.
  • Automatic downloading - The download scripts will be removed, so that users will need to use wget themselves. This will remove external library dependencies upon bs4 and requests.
  • Automated bounds checking - The code currently does a lot of automated checks to make sure the catalog has been properly formatted. All of this will now be punted to the user. This will make it possible to relax many current requirements, such as the current requirement that every column name begin with halo_.
  • RockstarHlistReader - This is really just a wrapper around TabularAsciiReader, which will remain.

Most (though not necessarily all) of the removed features will be migrated to a separate location that, in practice, users will need to maintain themselves. The timescale for this proposed migration is ~December 2019, so anyone with particular needs for these features should weigh in soon.

@aphearin aphearin added this to the v0.7 milestone Oct 28, 2019
@aphearin aphearin self-assigned this Oct 28, 2019
@aphearin aphearin changed the title Remove non-essential sim_manager features out of halotools Remove non-essential sim_manager features from halotools Oct 28, 2019
@aphearin aphearin modified the milestones: v0.7, next-release Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant