Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into submitting adc-streaming for inclusion to conda-forge #27

Open
mjuric opened this issue Apr 1, 2020 · 5 comments
Open

Look into submitting adc-streaming for inclusion to conda-forge #27

mjuric opened this issue Apr 1, 2020 · 5 comments

Comments

@mjuric
Copy link
Member

mjuric commented Apr 1, 2020

We should look into submitting adc-streaming to conda-forge, to make it easy for downstream dependences to install.

This would require creating a feedstock from the current recipe, and understand how we'd want to manage the in-package recipe vs. having it fully in the feedstock.

@myNameIsPatrick
Copy link
Collaborator

@mjuric, @spenczar, the current method for determining the version is incompatible with a conda-forge feedstock, since it requires the package to be installed from a git repository and we need to be able to install the package from an archive.

Running command python setup.py egg_info
    fatal: not a git repository (or any of the parent directories): .git
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/tmp/pip-req-build-iqs0q977/setup.py", line 93, in <module>
        version=git_version(),
      File "/private/tmp/pip-req-build-iqs0q977/setup.py", line 32, in git_version
        version = check_output(command.split()).decode('utf-8').strip()
      File "/Users/runner/miniforge3/conda-bld/adc-streaming_1616459830588/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.6/subprocess.py", line 356, in check_output
        **kwargs).stdout
      File "/Users/runner/miniforge3/conda-bld/adc-streaming_1616459830588/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.6/subprocess.py", line 438, in run
        output=stdout, stderr=stderr)
    subprocess.CalledProcessError: Command '['git', 'describe', '--tags', '--long', '--dirty', '--always']' returned non-zero exit status 128.

@mjuric
Copy link
Member Author

mjuric commented Mar 23, 2021

Hi Patrick, where is the draft feedstock code (to understand the problem better...)?

@myNameIsPatrick
Copy link
Collaborator

Re-submitted to staged-recipes: conda-forge/staged-recipes#16369

@myNameIsPatrick
Copy link
Collaborator

Now on conda-forge: https://anaconda.org/conda-forge/adc-streaming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants