Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce conditional run for 1000 models in performance tests #1410

Open
pankajkoti opened this issue Dec 19, 2024 · 1 comment
Open

Introduce conditional run for 1000 models in performance tests #1410

pankajkoti opened this issue Dec 19, 2024 · 1 comment
Labels
area:performance Related to performance, like memory usage, CPU usage, speed, etc stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed

Comments

@pankajkoti
Copy link
Contributor

pankajkoti commented Dec 19, 2024 •
edited
Loading

PR #1403 introduced running 500 & 1000 models in the matrix for the performance tests jobs. However, I'm observing that running although the job for 500 models finished in roughly 12-15 mins, the job for 1000 models runs for about 40+ mins. I suggest we drop running 1000 models with PR ##1411 and later introduce these 1000 models to run on a conditional basis e.g. when a certain label (run-large-no-models) is added to the PR.
@dosubot dosubot bot added the area:performance Related to performance, like memory usage, CPU usage, speed, etc label Dec 19, 2024
@pankajkoti pankajkoti mentioned this issue Dec 19, 2024
Merged
pankajkoti added a commit that referenced this issue Dec 19, 2024
@pankajkoti
Drop running 1000 models in the CI (#1411)
c5edba0 
With PR #1403 , we added to the matrix to run tests on 500 & 1000
models. Although the job for
500 models completes in under 15 mins, the job for 1000 models is taking
significantly longer ~40+ mins as can be seen here
https://github.com/astronomer/astronomer-cosmos/actions/runs/12400943145/job/34619249671.

I suggest we drop running 1000 models and later add it to the matrix to
conditionally run only when a certain label is added to the PR i.e. when
we would actually like to benchmark on specific PRs. I have created a
follow-up issue for this
#1410

related: #1410
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:performance Related to performance, like memory usage, CPU usage, speed, etc stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pankajkoti