877 automated e2e tests #886
Conversation
- Add github action dispatch job - Add line_profiler as fink-science dep - Import science module only if needed - Move fink-science dep to science requirements - Set py4j log level to INFO - Add logging messages for raw2science and distribute - Remove useless fink wait script
fjammes
force-pushed
the
877-automated-e2e-tests
branch
4 times, most recently
from
519c2c5 to
d7bb151
Compare
There was a problem hiding this comment.
Thanks @fjammes , it looks good to me! Thanks for the refactoring of the scientific part of the code 💪
Concerning the fact that there are no topics in the output, try to increase the number of alerts launched by the simulator:
bin/raw2science.py
Outdated
| if args.noscience: | ||
| fsvsn = "no-science" | ||
| else: | ||
| # Do not import fink_science if --noscience is set |
There was a problem hiding this comment.
I would put this comment above in the logger:
if args.noscience:
logger.debug("Do not import fink_science as --noscience is set")
fsvsn = "no-science"
else:
...
doc/troubleshoot.md
Outdated
| /s5cmd --log debug --no-verify-ssl ls -H "s3://fink-broker-online/raw/2020/01/01/" |
There was a problem hiding this comment.
It should be:
s3://fink-broker-online/raw/20200101
486a9e9 to
0a7a209
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #886 +/- ##
=====================================
- Coverage 84% 84% -1%
=====================================
Files 21 21
Lines 1292 1330 +38
=====================================
+ Hits 1092 1121 +29
- Misses 200 209 +9 ☔ View full report in Codecov by Sentry. |
fjammes
force-pushed
the
877-automated-e2e-tests
branch
from
0a7a209 to
433b557
Compare
fjammes
force-pushed
the
877-automated-e2e-tests
branch
from
433b557 to
0bca0c3
Compare
|
|
@JulienPeloton , FYI I have added a "noscience" pipeline, because the Github one is down. |
|
LGTM |
|
Why did you close this PR? |
|
My mistake, I wanted to merge it, I have merged it manually... |
|
:D |
IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): Closes #877
What changes were proposed in this pull request?
Tools to run self-hosted CI on a linux server and GHA integration.
How was this patch tested?
On fink server @lpc