-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concerns with zip version 1.x #3642
Comments
See also: PyO3/python-pkginfo-rs#13 |
We're still considering this as a team, but it seems likely we'd pin until we have more details. Would you be willing to open a pull request? |
Sure! I hope #3645 is what you needed. Thanks for considering this. |
## Summary Restore API-compatibility with pre-1.1.0 versions of the `zip` crate, and pin the dependency to the 0.6 series, due to concerns discussed in #3642. ## Test Plan ``` cargo run -p uv-dev -- fetch-python cargo test ```
In astral-sh/ruff#11779, we're adding |
I am working on packaging
uv
for Fedora Linux. Currently, we are wary of updating thezip
crate past version 0.6.x (and will hold off on doing so for now) due to concerns with how thezip-rs
project project is being handled:All releases starting with v1.0.0 were developed and released by different people than the original crate, with the hand-off being handled in a kind of weird way. Additionally, releases 1.2.0+ of the "new" zip crate contain breaking API changes which are not going to be fixed in the 1.x series.
Since
uv
can be made to work with version 0.6.6, would it be possible to either:zip
0.6.6
for now, if you decide you share these concerns, or:>=0.6.6, <2.0
to explicitly allow building with bothzip
v0.6 and v1?Note that the
zip
crate maintainer is planning a 2.0 release in a couple of weeks.In order to build with
zip
0.6.6
, with tests passing, one source change is necessary:uv/crates/install-wheel-rs/src/wheel.rs
Line 14 in 39af09f
needs to be
use zip::write::FileOptions as SimpleFileOptions
, since theSimpleFileOptions
alias was added in 1.x.If the
uv
project decides to change nothing, I will just carry a small downstream patch to supportzip
0.6.6
for the time being.The text was updated successfully, but these errors were encountered: