Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release atteststions #343

Open
orf opened this issue Oct 8, 2024 · 6 comments · May be fixed by #371
Open

Add release atteststions #343

orf opened this issue Oct 8, 2024 · 6 comments · May be fixed by #371
Labels
enhancement New feature or request

Comments

@orf
Copy link

orf commented Oct 8, 2024

Hello!

First, thanks for this fantastic project - it’s a great help to the community and ecosystem at large.

I would like to suggest adding artifact attestations to the releases.

This would enable supply chain verification for these builds, and provide a layer of validation above just verifying the signature.

it’s pretty simple to add: just a single step, with no configuration or changes required in the binary itself.

what do you think?

@zanieb
Copy link
Member

zanieb commented Oct 8, 2024

Yeah these seem reasonable, were you interested in contributing this?

@orf
Copy link
Author

orf commented Oct 8, 2024 via email

orf added a commit to orf/python-build-standalone that referenced this issue Oct 16, 2024
@orf orf linked a pull request Oct 16, 2024 that will close this issue
@chludwig-haufe
Copy link

I see there is an open PR #371, but no further activity. Is there anything blocking the creation of the attestations?

Since I didn't see this mentioned in the documentation: How is the integrity of the Python sources and dependencies used in the build verified?

@indygreg
Copy link
Collaborator

We pin and verify the sha256 and file size of all downloaded assets. See downloads.py.

@zanieb
Copy link
Member

zanieb commented Dec 16, 2024

@chludwig-haufe there's a blocking comment at #371 (comment)

@orf
Copy link
Author

orf commented Dec 16, 2024

@chludwig-haufe there's a blocking comment at #371 (comment)

Yep! I have this PR in my backlog, but some personal stuff has come up.

We should indeed only attest on main (or anything that actually publishes), adding the relevant if: blocks should be all that is needed.

@charliermarsh charliermarsh added the enhancement New feature or request label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants