Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access-controlled search for Rocket.Chat #14

Open
4 tasks
mrsimpson opened this issue Oct 26, 2017 · 0 comments
Open
4 tasks

Access-controlled search for Rocket.Chat #14

mrsimpson opened this issue Oct 26, 2017 · 0 comments

Comments

@mrsimpson
Copy link
Member

mrsimpson commented Oct 26, 2017

Motivation

As a user of Assistify (with the Rocket.Chat frontend), I want to be able to find conversations I had in the past. Thus, I would like to search also normal channels and even private conversations with a full-text search.

Implementation boundaries

  • This involves modifications to Rocket.Chat core. All this modification shall be contributed. See [NEW] Connection of external search providers in spotlight RocketChat/feature-requests#745 for the necessary boundaries. Commit to in order to keep communication simple
  • The data replicated shall include an access control list. The API will propagate the user searching. => The user shall only find messages of rooms which he'll be able to open afterwards.
  • The events relevant to the external search are denoted in the linked issue. Particular reacting on changes to the permissions might invalidate a lot of the ACLs.
  • It might make sense to add methods to the API which allow the search provider to propagate a status. But that's surely something you already have got experiences with ;)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant