50 showroom | top bar #54
Conversation
|
@florin-baciu, lasa te rog o imagine din figma si cu rezultatul la ce ai facut tu ca sa imi dau seama mai usor despre ce e vorba. |
|
@victorjeman Updated the description of the PR |
|
|
||
| const categories = [{ name: 'Category 1' }, { name: 'Category 2' }, { name: 'Category 3' }] | ||
|
|
||
| const onCityChange = (e: any) => { |
There was a problem hiding this comment.
Un type pentru event, te rog
| value={selectCategory} | ||
| options={categories} | ||
| onChange={onCityChange} | ||
| optionLabel='name' |
There was a problem hiding this comment.
Pune constante, te rog
| import { useStore } from 'store/store' | ||
|
|
||
| import { ReactComponent as AssistLogo } from 'common/assets/logo-assist.svg' | ||
| import { ReactComponent as UserIcon } from './../../assets/user-icon.svg' |
There was a problem hiding this comment.
sa folosim mereu absolute paths.
| import { useState } from 'react' | ||
|
|
||
| import { AUTH_PAGES, PAGES_PATHS } from 'common/constants/constants' | ||
| import { InputText } from 'primereact/inputtext' |
There was a problem hiding this comment.
sa grupam importurile din node_modules si custom imports si sa lasam un spatiu intre ele.
|
Un comentariu mai general. O buna parte din functionalitatile din top bar eu le vad ca parte din alte features. Search My account dropdown Favourites + ASSIST logo pot sa faca parte din componenta generica "top-bar" care o putem pune in common/components cc: @florin-baciu |
Figma:
APP:
