Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization of Microsoft.AspNet.WebApi.Client package is missing some resources #399

Open
dougbu opened this issue Mar 10, 2023 · 2 comments
Assignees
Labels
Milestone

Comments

@dougbu
Copy link
Member

dougbu commented Mar 10, 2023

Resources added in this repo lately are not reflected in the TFS content. For example, git diff v3.2.9 --ignore-space-at-eol -- src/**/*.resx shows

+  <data name="Argument_InvalidOffLen" xml:space="preserve">
+    <value>Offset and length were out of bounds for the array or count is greater than the number of elements from index to the end of the source collection.</value>
+  </data>
+  <data name="NotSupported_UnreadableStream" xml:space="preserve">
+    <value>Stream does not support reading.</value>
+  </data>
+  <data name="NotSupported_UnseekableStream" xml:space="preserve">
+    <value>Stream does not support seeking.</value>
+  </data>
+  <data name="NotSupported_UnwritableStream" xml:space="preserve">
+    <value>Stream does not support writing.</value>
+  </data>
+  <data name="ObjectDisposed_StreamClosed" xml:space="preserve">
+    <value>Cannot access a closed stream.</value>
+  </data>
+  <data name="JsonMediaTypeFormatter_DCS_NotSupported" xml:space="preserve">
+    <value>Unable to validate types on this platform when {0} is 'true'. Please reset {0} or move to a supported platform, one where the .NET Standard 2.0 assembly is usable.</value>
+  </data>
+  <data name="XmlMediaTypeFormatter_DCS_NotSupported" xml:space="preserve">
+    <value>Unable to validate types on this platform when {0} is 'false'. Please set {0} or move to a supported platform, one where the .NET Standard 2.0 assembly is usable.</value>
+  </data>

None of those resources are mentioned in https://vstfdevdiv/DevDiv2/DevDiv/_versionControl?path=%24/DevDiv/Offcycle/WPT/WebStackRuntime/Main/localize/comments/System.Net.Http.Formatting.resources.dll.lci, https://vstfdevdiv/DevDiv2/DevDiv/_versionControl?path=%24/DevDiv/Offcycle/WPT/WebStackRuntime/Main/localize/CHS/System.Net.Http.Formatting.resources.dll.lcl, or other translation files.

The necessary work here is to onboard the TFS repo or perhaps the TeamCity build w/ the loc team (Cristiano can help), build a new loc project, hand it off to the loc team, then check in the updated translated files. That may cause additional changes and perhaps improvements.

@dougbu
Copy link
Member Author

dougbu commented Mar 10, 2023

Probably need to change https://vstfdevdiv/DevDiv2/DevDiv/_versionControl?path=%24/DevDiv/Offcycle/WPT/WebStackRuntime/Main/Loc.proj&version=T so that setting $(AutoUpdateLCL) in a Main.Signed.AllLanguages build doesn't try to use $(AutoUpdateTfsCollection) or TFS at all but does create the loc project. Changing the artifacts in the build configuration should ensure the loc project doesn't just sit on the build agents.

@mkArtakMSFT
Copy link
Member

Thank you, @dougbu!

@mkArtakMSFT mkArtakMSFT added this to the Backlog milestone Jun 14, 2023
@mkArtakMSFT mkArtakMSFT removed their assignment Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants