-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flow blocks wip #22
Draft
evren-okcu
wants to merge
6
commits into
master
Choose a base branch
from
flow-blocks-wip
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+997
−19
Draft
Flow blocks wip #22
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
block-beta | ||
columns 7 | ||
space:5 Sink1 space:1 | ||
space:1 Source space:1 Split space:3 | ||
space:5 Sink2 space:1 | ||
Source-- "input" -->Split | ||
Split-- "output_1" -->Sink1 | ||
Split-- "output_2" -->Sink2 | ||
|
||
classDef block height:48px,padding:8px; | ||
classDef hidden visibility:none; | ||
class Split block | ||
class Source hidden | ||
class Sink1 hidden | ||
class Sink2 hidden |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
sequenceDiagram | ||
autonumber | ||
participant BlockA as Another block | ||
participant Split.input as Split.input port | ||
participant Split as Split block | ||
participant Split.output_1 as Split.output_1 port | ||
participant BlockB as Another block | ||
participant Split.output_2 as Split.output_2 port | ||
participant BlockC as Another block | ||
|
||
BlockA-->>Split: Connect | ||
Split-->>BlockB: Connect | ||
Split-->>BlockC: Connect | ||
|
||
loop Split process | ||
BlockA->>Split: Message | ||
Split->>Split: Decide the next output port | ||
Split->>BlockB: Message | ||
BlockA->>Split: Message | ||
Split->>Split: Decide the next output port | ||
Split->>BlockC: Message | ||
end | ||
|
||
BlockA-->>Split: Disconnect | ||
Split-->>Split.input: Close | ||
Split-->>Split.output_1: Close | ||
Split-->>BlockB: Disconnect | ||
Split-->>Split.output_2: Close | ||
Split-->>BlockC: Disconnect |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1,30 +1,138 @@ | ||||||||||||||||||
// This is free and unencumbered software released into the public domain. | ||||||||||||||||||
|
||||||||||||||||||
pub mod flow { | ||||||||||||||||||
use crate::{InputPortName, OutputPortName}; | ||||||||||||||||||
|
||||||||||||||||||
use super::{ | ||||||||||||||||||
prelude::{Cow, Named}, | ||||||||||||||||||
BlockConnections, BlockInstantiation, | ||||||||||||||||||
prelude::{vec, Box, Cow, Named, Vec}, | ||||||||||||||||||
BlockConnections, BlockInstantiation, System, | ||||||||||||||||||
}; | ||||||||||||||||||
|
||||||||||||||||||
pub trait FlowBlocks {} | ||||||||||||||||||
use protoflow_core::{Block, Message}; | ||||||||||||||||||
|
||||||||||||||||||
pub trait FlowBlocks { | ||||||||||||||||||
fn concat<T: Message + Into<T> + 'static>(&mut self) -> Concat<T>; | ||||||||||||||||||
fn replicate<T: Message + Into<T> + 'static>(&mut self) -> Replicate<T>; | ||||||||||||||||||
fn sort<T: Message + Into<T> + PartialOrd + 'static>(&mut self) -> Sort<T>; | ||||||||||||||||||
fn split<T: Message + Into<T> + 'static>(&mut self) -> Split<T>; | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ||||||||||||||||||
#[derive(Clone, Copy, Debug, Eq, Hash, Ord, PartialEq, PartialOrd)] | ||||||||||||||||||
pub enum FlowBlockTag {} | ||||||||||||||||||
pub enum FlowBlockTag { | ||||||||||||||||||
Concat, | ||||||||||||||||||
Replicate, | ||||||||||||||||||
Sort, | ||||||||||||||||||
Split, | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ||||||||||||||||||
#[derive(Clone, Debug)] | ||||||||||||||||||
pub enum FlowBlockConfig {} | ||||||||||||||||||
pub enum FlowBlockConfig { | ||||||||||||||||||
Concat { | ||||||||||||||||||
input_1: InputPortName, | ||||||||||||||||||
input_2: InputPortName, | ||||||||||||||||||
output: OutputPortName, | ||||||||||||||||||
}, | ||||||||||||||||||
Replicate { | ||||||||||||||||||
input: InputPortName, | ||||||||||||||||||
output_1: OutputPortName, | ||||||||||||||||||
output_2: OutputPortName, | ||||||||||||||||||
}, | ||||||||||||||||||
Sort { | ||||||||||||||||||
input: InputPortName, | ||||||||||||||||||
stop: InputPortName, | ||||||||||||||||||
output: OutputPortName, | ||||||||||||||||||
}, | ||||||||||||||||||
Split { | ||||||||||||||||||
input: InputPortName, | ||||||||||||||||||
output_1: OutputPortName, | ||||||||||||||||||
output_2: OutputPortName, | ||||||||||||||||||
}, | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
impl Named for FlowBlockConfig { | ||||||||||||||||||
fn name(&self) -> Cow<str> { | ||||||||||||||||||
unreachable!() | ||||||||||||||||||
use FlowBlockConfig::*; | ||||||||||||||||||
Cow::Borrowed(match self { | ||||||||||||||||||
Concat { .. } => "Concat", | ||||||||||||||||||
Replicate { .. } => "Replicate", | ||||||||||||||||||
Sort { .. } => "Sort", | ||||||||||||||||||
Split { .. } => "Split", | ||||||||||||||||||
}) | ||||||||||||||||||
} | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
impl BlockConnections for FlowBlockConfig {} | ||||||||||||||||||
impl BlockConnections for FlowBlockConfig { | ||||||||||||||||||
fn output_connections(&self) -> Vec<(&'static str, Option<OutputPortName>)> { | ||||||||||||||||||
use FlowBlockConfig::*; | ||||||||||||||||||
match self { | ||||||||||||||||||
Concat { output, .. } => { | ||||||||||||||||||
vec![("output", Some(output.clone()))] | ||||||||||||||||||
} | ||||||||||||||||||
Replicate { | ||||||||||||||||||
output_1, output_2, .. | ||||||||||||||||||
} => { | ||||||||||||||||||
vec![ | ||||||||||||||||||
("output_1", Some(output_1.clone())), | ||||||||||||||||||
("output_2", Some(output_2.clone())), | ||||||||||||||||||
] | ||||||||||||||||||
} | ||||||||||||||||||
Sort { output, .. } => { | ||||||||||||||||||
vec![("output", Some(output.clone()))] | ||||||||||||||||||
} | ||||||||||||||||||
Split { | ||||||||||||||||||
output_1, output_2, .. | ||||||||||||||||||
} => { | ||||||||||||||||||
vec![ | ||||||||||||||||||
("output_1", Some(output_1.clone())), | ||||||||||||||||||
("output_2", Some(output_2.clone())), | ||||||||||||||||||
] | ||||||||||||||||||
} | ||||||||||||||||||
} | ||||||||||||||||||
} | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
impl BlockInstantiation for FlowBlockConfig { | ||||||||||||||||||
fn instantiate(&self, system: &mut System) -> Box<dyn Block> { | ||||||||||||||||||
use super::SystemBuilding; | ||||||||||||||||||
use FlowBlockConfig::*; | ||||||||||||||||||
match self { | ||||||||||||||||||
Concat { .. } => Box::new(super::Concat::new( | ||||||||||||||||||
system.input_any(), | ||||||||||||||||||
system.input_any(), | ||||||||||||||||||
system.output(), | ||||||||||||||||||
)), | ||||||||||||||||||
Replicate { .. } => Box::new(super::Replicate::new( | ||||||||||||||||||
system.input_any(), | ||||||||||||||||||
system.output(), | ||||||||||||||||||
system.output(), | ||||||||||||||||||
)), | ||||||||||||||||||
Sort { .. } => Box::new(super::Sort::new( | ||||||||||||||||||
system.input_any(), | ||||||||||||||||||
SamuelSarle marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||
system.input(), | ||||||||||||||||||
system.output(), | ||||||||||||||||||
)), | ||||||||||||||||||
Comment on lines
+111
to
+115
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||
Split { .. } => Box::new(super::Split::new( | ||||||||||||||||||
system.input_any(), | ||||||||||||||||||
system.output(), | ||||||||||||||||||
system.output(), | ||||||||||||||||||
)), | ||||||||||||||||||
} | ||||||||||||||||||
} | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
mod concat; | ||||||||||||||||||
pub use concat::*; | ||||||||||||||||||
|
||||||||||||||||||
mod replicate; | ||||||||||||||||||
pub use replicate::*; | ||||||||||||||||||
|
||||||||||||||||||
mod sort; | ||||||||||||||||||
pub use sort::*; | ||||||||||||||||||
|
||||||||||||||||||
impl BlockInstantiation for FlowBlockConfig {} | ||||||||||||||||||
mod split; | ||||||||||||||||||
pub use split::*; | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
pub use flow::*; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this creates a block from the BlockTag, not sure if it is right to create Sort block only with String typed ports