Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the notify update optional #104

Open
nikaiw opened this issue Aug 22, 2024 · 2 comments
Open

Make the notify update optional #104

nikaiw opened this issue Aug 22, 2024 · 2 comments
Labels
enhancement New feature or request triage Issue needs triage

Comments

@nikaiw
Copy link

nikaiw commented Aug 22, 2024

When being run aterm is checking for updates. However it might not be practical when running in a disconnected environement

Can you make the following call optional e.g from a configuration value ?:

appdialogs.NotifyUpdate(config.Version(), config.CodeOwner(), config.CodeRepo())

@nikaiw nikaiw added enhancement New feature or request triage Issue needs triage labels Aug 22, 2024
@jrozner
Copy link
Member

jrozner commented Aug 27, 2024

Ya, this is definitely something that we can make optional. Is this something that you're ok with being controlled from the config file and being default on but controllable via the setup routine?

@nikaiw
Copy link
Author

nikaiw commented Aug 28, 2024

Yeah, I think it would be fine to have it on by default as long as it is at least controllable either via a config file or a command line argument (or both)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Issue needs triage
Projects
None yet
Development

No branches or pull requests

2 participants