Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still seeing "this function takes 4 arguments but 2 arguments were supplied" errors in Vulkan CI #962

Open
oddhack opened this issue Nov 18, 2024 · 1 comment

Comments

@oddhack
Copy link

oddhack commented Nov 18, 2024

ISTR talking about this but can't find the issue now - sorry if this is a dup. The problem with new attributes is gone - thanks! - but we're still seeing errors in ash-generate (gitlab) / build-test (Github) of form

error[E0061]: this function takes 4 arguments but 2 arguments were supplied
289
--> ash/src/extensions/amdx/shader_enqueue.rs:77:9

They seem to be confined to the one corresponding AMDX extension, which is interestingly weird.

@MarijnS95
Copy link
Collaborator

Hey yes, I just put an update in the latest issue that you filed, at #959 (comment):

After merging and re-running the CI code generation is once again successful, but compiling still fails because of #343 (comment), which I hope to solve entirely with #952 or at the very least fix in #951.

I probably need to discuss with @Ralith how we should design + release a fix for this in the near future. Perhaps I might just merge #951 to master and that should fix your immediate build issues.

That immediately preps us for the next breaking release, so I might be branching off at that point in case we want to aim for a nonbreaking release before this point.

@MarijnS95 MarijnS95 added this to the Ash 0.39 with Vulkan 1.4 milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants