Skip to content
This repository has been archived by the owner on Sep 8, 2020. It is now read-only.

Cast entities values assignments #42

Open
beroso opened this issue Jun 2, 2017 · 0 comments
Open

Cast entities values assignments #42

beroso opened this issue Jun 2, 2017 · 0 comments
Labels
BC break Changes in this PR/issue would result in a BC break enhancement This adds new functionality or improves existing functionality.

Comments

@beroso
Copy link

beroso commented Jun 2, 2017

The parser are storing SimpleXML elements in the entities properties.
I think, for example, the code from Parser::buildCreditAccount:

....
$bankAccount->accountNumber = $statementResponse->BANKACCTFROM->ACCTID;
$bankAccount->routingNumber = $statementResponse->BANKACCTFROM->BANKID;
$bankAccount->accountType = $statementResponse->BANKACCTFROM->ACCTTYPE;
....

should be:

....
$bankAccount->accountNumber = (string)$statementResponse->BANKACCTFROM->ACCTID;
$bankAccount->routingNumber = (string)$statementResponse->BANKACCTFROM->BANKID;
$bankAccount->accountType = (string)$statementResponse->BANKACCTFROM->ACCTTYPE;
....
@asgrim asgrim added enhancement This adds new functionality or improves existing functionality. BC break Changes in this PR/issue would result in a BC break labels Oct 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
BC break Changes in this PR/issue would result in a BC break enhancement This adds new functionality or improves existing functionality.
Projects
None yet
Development

No branches or pull requests

2 participants