Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grunt error #71

Open
joanvila opened this issue Apr 15, 2016 · 1 comment
Open

Grunt error #71

joanvila opened this issue Apr 15, 2016 · 1 comment

Comments

@joanvila
Copy link
Contributor

Hi!

I was making some changes to the repository to contribute but I ran into a problem.

After doing the modifications I had in mind I ran the grunt command to generate the minified files and the the other checks. However, I got this error:

Testing jasmine specs via PhantomJS

exposed internal components
 x Expected '' to be '0px'. (1)
 x Expected '' to be '-200px'. (1)

>> 2 failures
Warning: Task "jasmine:test" failed. Use --force to continue.
Aborted due to warnings.

I am not a grunt or phantomJS expert and I don't recognise this error. If somebody has a clue about it I would appreciate it.

Thanks,
Joan

@ascott1
Copy link
Owner

ascott1 commented Apr 15, 2016

@joanvila

It's likely that your changes caused these two tests to fail:

https://github.com/ascott1/bigSlide.js/blob/master/test/big-slide.spec.js#L134
https://github.com/ascott1/bigSlide.js/blob/master/test/big-slide.spec.js#L125

If those are intended changes, you can update the tests.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants