Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EasyClose Issue in iOS 9.3 Safari #67

Open
eric432 opened this issue Mar 30, 2016 · 5 comments
Open

EasyClose Issue in iOS 9.3 Safari #67

eric432 opened this issue Mar 30, 2016 · 5 comments

Comments

@eric432
Copy link

eric432 commented Mar 30, 2016

It seems with easyClose set to true the menu only closes if you click an actual link in the page (instead of anywhere). In desktop browsers and android I can close by clicking anywhere on the page. I am seeing this behavior on the bigslide.js homepage as well so I suspect it is an new iOS issue?

@ascott1
Copy link
Owner

ascott1 commented Mar 31, 2016

😞 That's very possible. I've seen other (similar) unexpected behavior in iOS Safari 9+.

@ghost
Copy link

ghost commented Apr 10, 2016

I tried adding touchstart.bigSlide event on line 203. Seemed to do the job for iOS 9.2 - havent tried 9.3.

@mzane42
Copy link

mzane42 commented Jul 11, 2016

thanks @topcatcreatives !

@timmeade
Copy link

timmeade commented Sep 1, 2016

Current version i have has touchstart.bigSlide on line 204 and I am having an issue with this not closing on touch.... ios 9.3.5

Any other suggestions? I like this tool, but this is a must fix ....

@timmeade
Copy link

timmeade commented Sep 1, 2016

Ok Line 251 added touchstart.bigSlide fixed my issue:

    if (settings.easyClose) {
      $(document).on('click.bigSlide touchstart.bigSlide', function(e) {
       if (!$(e.target).parents().addBack().is(menuLink) && !$(e.target).closest(settings.menu).length && controller.getState() === 'open')  {
         view.toggleClose();
       }
      });
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants