From 06f4336c6cea1626722f12bbb2659e48d5ab4581 Mon Sep 17 00:00:00 2001
From: Fintan Bolton <fbolton@redhat.com>
Date: Thu, 12 Oct 2023 11:16:39 +0200
Subject: [PATCH] fixed links to images (PR #59)

---
 lib/docbookrx/docbook_visitor.rb     |  3 +++
 spec/lib/docbookrx/docbookrx_spec.rb | 34 +++++++++++++++++++++++++++-
 2 files changed, 36 insertions(+), 1 deletion(-)

diff --git a/lib/docbookrx/docbook_visitor.rb b/lib/docbookrx/docbook_visitor.rb
index 47162fe..f20ef58 100644
--- a/lib/docbookrx/docbook_visitor.rb
+++ b/lib/docbookrx/docbook_visitor.rb
@@ -1497,6 +1497,9 @@ def visit_screenshot node
   # FIXME share logic w/ visit_inlinemediaobject, which is the same here except no block_title and uses append_text, not append_line
   def visit_figure node
     append_blank_line
+    if (id = (resolve_id node, normalize: @normalize_ids))
+      append_line %([[#{id}]])
+    end
     append_block_title node
     if (image_node = node.at_css('imageobject imagedata'))
       src = image_node.attr('fileref')
diff --git a/spec/lib/docbookrx/docbookrx_spec.rb b/spec/lib/docbookrx/docbookrx_spec.rb
index 446f6ce..1055a27 100644
--- a/spec/lib/docbookrx/docbookrx_spec.rb
+++ b/spec/lib/docbookrx/docbookrx_spec.rb
@@ -1149,7 +1149,39 @@
     EOS
     output = Docbookrx.convert input
     expect(output).to eq(expected)
-end
+  end
+
+  it 'adds an XML ID for figures' do
+
+    input = <<-EOS
+<article xmlns='http://docbook.org/ns/docbook'
+         xmlns:xl="http://www.w3.org/1999/xlink"
+         version="5.0" xml:lang="en">
+  <para>See <xref linkend="sample-figure"/>
+  <figure xml:id="sample-figure">
+    <title>Local History</title>
+    <mediaobject>
+      <imageobject>
+        <imagedata fileref="images/dummy.png"/>
+      </imageobject>
+    </mediaobject>
+  </figure>
+
+</article>
+    EOS
+
+    expected = <<-EOS.rstrip
+See <<_sample_figure>>
+
+[[_sample_figure]]
+.Local History
+image::images/dummy.png[]
+    EOS
+
+    output = Docbookrx.convert input
+
+    expect(output).to include(expected)
+  end
 
   it 'should correctly convert varlistentry elements with nested lists' do
     input = <<-EOS