Issue 619 Bug: Solving a system of equations... #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lyticalEquationSolver.Solve( "{-(x + -1000) / (-1)}", "{x}" ) was returning "{{ } \/ { 1000 } \ { }}". That wasn't being interpreted as a FiniteSet. Getting InnerSimplified results in "{1000}", and that fits the FiniteSet type.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#619
I added tests with the inputs described in the issue to the SolveSystem tests.
During debugging, I found that
AnalyticalEquationSolver.Solve( "{-(x + -1000) / (-1)}", "{x}" )was returning
"{{ } \/ { 1000 } \ { }}"That value wasn't fitting the FiniteSet type in the ternary within EquationSolver.InSolveSystem.
I tried simply getting InnerSimplified of the solution, and that worked for the new test cases and didn't break the old ones.
Maybe this isn't the right place to simplify, or FiniteSet should accept the value as is.