Delay JS parsing until Document Ready #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Best practice advises loading jQuery and other libraries at the end of a page’s HTML. To allow for correct operation in projects loading jQuery at the foot of the document, this PR wraps the inline <script> tag contents in a browser-compatible DOM Ready event handler lifted from here: https://gist.github.com/dciccale/4087856.
|
Is this package dead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best practice advises loading jQuery and other JS libraries at the end of a page’s HTML. To allow for correct operation in projects loading jQuery at the foot of the document, this PR wraps the inline <script> tag contents in a browser-compatible DOM Ready event handler lifted from here: https://gist.github.com/dciccale/4087856.
This improves upon #72 by being more cross-browser compatible.