Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support UTC time stamps in logs #54

Open
aryoda opened this issue Apr 19, 2020 · 1 comment
Open

Support UTC time stamps in logs #54

aryoda opened this issue Apr 19, 2020 · 1 comment

Comments

@aryoda
Copy link
Owner

aryoda commented Apr 19, 2020

The current implementation seems to log local times, not UTC.

This makes it difficult to correlate log entries of different services on the same and other computers to get a holistic picture of log events.

The internal implementations uses

timestamp <- Sys.time()

which returns an absolute date-time value of class POSIXct but when a log entry is created the local time zone may be applied...

@aryoda
Copy link
Owner Author

aryoda commented Jul 31, 2022

On the other hand using only UTC drives me crazy when I try to understand logs and my timezone is different (eg. searching and filtering requires time zone calculations).

I suggest to add another column named "timezone.UTC" to build.log.entry() to let the user see both time zones (local + UTC).

And the time zone of the logging framework output should be left untouched in tryCatchLog since it is a configuration (or default setting) of the logging framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant