Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mode method #604

Open
14 of 32 tasks
aloctavodia opened this issue Dec 12, 2024 · 4 comments
Open
14 of 32 tasks

Add mode method #604

aloctavodia opened this issue Dec 12, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@aloctavodia
Copy link
Contributor

aloctavodia commented Dec 12, 2024

In #603 we introduced a mode argument to maxent and a mode method to many distributions. The mode is still missing from the following distributions.

  • AsymmetricLaplace
  • BetaScaled
  • ChiSquared
  • ExGaussian
  • Kumaraswamy
  • LogLogistic
  • LogitNormal
  • Pareto
  • Rice
  • SkewNormal
  • SkewStudentT
  • StudentT
  • TruncatedNormal
  • Uniform
  • VonMises
  • Wald
  • Weibull
  • BetaBinomial
  • Binomial
  • Categorical
  • DiscreteUniform
  • DiscreteWeibull
  • HyperGeometric
  • ZeroInflatedBinomial
  • ZeroInflatedNegativeBinomial
  • ZeroInflatedPoisson
  • Dirichlet
  • MultiVariateNormal
  • Hurdle
  • Censored
  • Truncated
  • Mixture
@rohanbabbar04
Copy link
Contributor

I have a question: there are some distributions that are bimodal. Should we return both modes or just one?

@aloctavodia
Copy link
Contributor Author

Good question. Maybe only the major mode? Not sure what to do if two equal modes.

Also for the beta and beta scaled, I think we are currently returning 0.5 when alpha and beta are lower than 1. But we should do:

0.5 if α=β = 1
No mode if α<1 OR β<1.
at 0 for α ≤ 1, and at 1 if β ≤ 1

@rohanbabbar04
Copy link
Contributor

One option is to go with the major one, other is to return a tuple of both modes

@aloctavodia
Copy link
Contributor Author

yep, probably the better thing is to respect multimodality. Then we will need to check that setting the mode works for maxent or that at least a warning is raised if we can not handle those cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants