-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitmoji and subject are somehow redundant #18
Comments
Thanks for your favor of this project and recommendation, I will try to figure it out to see whether can add this confuration.😄 And duration these time if you still want the previous version, you can lock the version of Beside, I want to explain the reasons why I add the commit type check rule. Firstly, the reason i add type check rule is that gitmoji is ambiguous, though it can indicated that the subject of this commit message. For example the And this's the second reasion to add commit type: to automatic manage version and to gernerate changelog. These two reason make me decide to add angular-commit style part to gitmoji commit style.(That's also a breaking change) Base on that I build the whole automatic workflow(I call it gitmoji-commit-workflow). |
I can understand the reason for this redundancy in order to use the text type to determine the changelog category, but I think what adds to this redundant feeling is the original commit message gitmoji being stripped out when generating the changelog. This sort of defeats the purpose of having it in the first place. With that said I would love for the changelog to include the gitmoji in the message. The text type would act at the major changelog header as it does now, and then the emojis would act as sort of a subcategory. So a series of commits like this would end up like the changelog posted below
1.1.0 (2021-03-29)Features
Bug Fixes
|
How can we achieve this? I love gitmoji style but I didn't like it when I should use the type. |
This module.exports = {
extends: ["gitmoji"],
rules: {
"type-empty": [2, "always"],
"subject-empty": [2, "always"],
},
}; |
originally in gitmoji 1.0, you use
enum-type
to enforce usage of gitmoji, that works great and I really enjoyed it.Now in 2.0, it seems commitlint-config-gitmoji not only enforces on the gitmoji, but also on the subject in coventional-commit, i think this is a bit redundant.
e.g.
git gitmoji has already indicated that the subject of this commit message is a bug, extra subject
bug:
is just way too tedious.i'd recommend to provide some configuration options to restore behavior of usage of only gitmoji without extra enum type being passed in.
e.g.
or with scope
The text was updated successfully, but these errors were encountered: