Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging message bug #155

Open
ana-kop opened this issue Oct 26, 2022 · 0 comments
Open

Logging message bug #155

ana-kop opened this issue Oct 26, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ana-kop
Copy link
Contributor

ana-kop commented Oct 26, 2022

A very minor issue, very similar incorrect logging messages in 2 functions:

  1. logging.info(f'Removed Services with IDs `{service_id}`, and Routes: {route_ids}')

  2. logging.info(f'Removed Routes with IDs {route_ids}, to Services `{service_id}`.')

Should use service_ids not service_id to list all services that have been removed/ from which routes have been removed

(In the second case, might make more sense for the message to say ...belonging to Services {service_ids}

@ana-kop ana-kop added bug Something isn't working good first issue Good for newcomers labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant