Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pivot item active property should support boolean #115

Open
ChaseIngebritson opened this issue Nov 23, 2020 · 1 comment · May be fixed by #116
Open

Pivot item active property should support boolean #115

ChaseIngebritson opened this issue Nov 23, 2020 · 1 comment · May be fixed by #116

Comments

@ChaseIngebritson
Copy link

Currently when a pivot-item within a pivot is provided the active property it provides the active class, regardless of the property's value. Unfortunately, this causes an issue with loops where all items will be set as active since the property disregards whether the value is truthy or falsy.

Here is the line that checks the active property if it helps.
@ChaseIngebritson ChaseIngebritson linked a pull request Nov 23, 2020 that will close this issue
Open
@theGeekyLad
Copy link

Hope this @ChaseIngebritson 's PR gets merged soon. At present, I've used a ref on each of the pivot items to conditionally add and remove active on the element. Not very thoughtful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(pivot): pivot-item active respects prop value ChaseIngebritson/vuent
2 participants
@ChaseIngebritson @theGeekyLad