Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular2Parse dependency prevents upgrade to angular 10/11 #364

Open
renegadeCode opened this issue Dec 28, 2020 · 3 comments
Open

Angular2Parse dependency prevents upgrade to angular 10/11 #364

renegadeCode opened this issue Dec 28, 2020 · 3 comments

Comments

@renegadeCode
Copy link

Not sure what can be done. I tried to do a PR fixing the issue angular2parse has with newer versions of Angular.

Intended outcome:
Upgrade angular to 10/11.

Actual outcome:
Failed upgrade because of angular-cesium's dependency on angular2parse.

How to reproduce the issue:
Use ng to upgrade angular to angular 11.

Version

@Crocsx
Copy link

Crocsx commented Feb 13, 2021

I forced the upgrade on angular 11 (didn't really checked this specific issue) and I am running with it without a problem.
It will potentially break in the future, but for a version bump to latest angular it is ok for the moment.

@aznguy
Copy link

aznguy commented Mar 30, 2021

Cool, You mean this fork? : https://github.com/Crocsx/angular-cesium
are there any plans for merging this into the original code base?

Or @Crocsx Maybe you can create a PR

@Crocsx
Copy link

Crocsx commented Mar 30, 2021

@aznguy No, this original repo works on angular 11 without issue. (I mean at least for what I use it) Only need to add the

"allowedCommonJsDependencies": ["geodesy", "util"],

to remove the compilation warnings.

I think you can try to force the update if you need.

My fork was a tentative to make this library works with the Cesium provided types (without having Cesium attached to the window object) and remove obsolete packages, but I kind of give up for now. ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants