Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes: #134] Placing textbox on screen #140

Merged
merged 2 commits into from
Dec 23, 2023

Conversation

sarthakvermaa
Copy link
Contributor

Issue number: #134
To check the position of the user input text box, I have set a condition of comparing dynamic text box height with 80% of the viewport height. Firstly I have created two text boxes in practice.html, and commented out the previous one.
Then, I styled them in practice.css. And at last, I added some elements in practice.mjs, and with the condition check I assigned the element to the variable declared in that file.
Hope it helped!

Copy link

vercel bot commented Dec 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typing-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2023 10:21am

@sarthakvermaa
Copy link
Contributor Author

@arpitghura Can you please tell why am I not able to do PR?

@arpitghura
Copy link
Owner

The functionality does not persists for easy - 2 minutes session. Look at it.
image

@sarthakvermaa
Copy link
Contributor Author

@arpitghura Well the functionality depends on the text box size. Here, if there are less than 12(>12) lines then only the input box is placed right below the reset button (keeping the condition "Sarthak, you have to make the text box inline that is placed just below the reset button when the dynamic-text-box height is less than 80% of the viewport height and when the height is greater than 80% then the current behavior is already written.The height is less in case of easy and intermediate difficulty and in case of less time sessions and also do check about these." asked in mind).
If there's any specific change needed I'll look at it.

@arpitghura arpitghura merged commit 6808ed8 into arpitghura:main Dec 23, 2023
2 of 3 checks passed
@arpitghura
Copy link
Owner

LGTM. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants