Removed obstructed line bug in 5 minutes challenge #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This PR will be reviewed till 6 June. Have patience 🫂 |
|
Can you please revert the changes back the changes made by prettier? |
arpitghura
requested changes
Jun 8, 2023
|
The issue comes in easy and intermediate session in which the scroll is not there. Issue can be resolved by checking the height of the |
|
Merging this PR, but some parts of the task remain uncompleted, which we cover in another issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @arpitghura ,
I hope you're doing well. I recently made a change to the Typing-test repository to address obstructed lines bug. However, after thorough testing, I've noticed that my solution didn't produce the desired outcome.
I wanted to bring this to your attention and kindly request your guidance. I'm eager to learn from this experience and improve my skills as a contributor. Any feedback or suggestions you can provide on what went wrong and possible alternative approaches would be greatly appreciated.
Thank you for your time and consideration. I value your expertise and the opportunity to contribute to this project.
Best regards,
Pritam Roy
I've added this 4 lines only but in PR it shows that I've done lot of changes. It is because of prettier code formatting.