Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facebook and Instagram logo not visible #929

Closed
1 of 3 tasks
Raj100 opened this issue Oct 12, 2023 · 8 comments · Fixed by #935
Closed
1 of 3 tasks

facebook and Instagram logo not visible #929

Raj100 opened this issue Oct 12, 2023 · 8 comments · Fixed by #935
Assignees

Comments

@Raj100
Copy link
Contributor

Raj100 commented Oct 12, 2023

Issue Type:

  • Bug Report
  • Feature Request
  • Documentaion

Describe the bug

In the coming soon template the facebook and instagram logos are not visible

Possible solution

  • We can add facebook and instagram logo svg or like and heart/follow logo as in facebook and instagram.

Screenshots

Screenshot
@github-actions
Copy link

Hello there!👋, @Raj100 Welcome to the Cool-Front-End_Templates project!🚀⚡Thank you and congrats🎉 for opening issue in this project. Please make sure not to start working on the issue, unless you get assigned to it.😄 currently we are not accepting new templates sorry for inconvenience u can checkout the issues which are opend or u can create a issue for improving any existing template

@github-actions
Copy link

Hi 😄, thanks for creating your first issue at Cool-Front-End_Templates project!🚀⚡ do read and follow the Code of Conduct while contributing.

@nitinryali
Copy link

Can you assign this to me?

@Raj100
Copy link
Contributor Author

Raj100 commented Oct 12, 2023

Assign it to me
I will make one more pull request based on suggestions

@arpit456jain
Copy link
Owner

arpit456jain commented Oct 12, 2023

go ahead @Raj100 and try to make it fully responsive and correct the timer , set it to some 2 years from now so that it can be in positive

@Raj100
Copy link
Contributor Author

Raj100 commented Oct 15, 2023

I can also make minimum changes to fix the bug should I do that? Or make the site to fit in view port?
Screenshot

Should I add bootstrap back and make minimum changes to the site ?
I removed bootstrap and coded myself and any suggestions or changes or Is the one that I made pull request fine?
Is the hover effect fine or should I make some other effect or keep previous?
And/or work on UI/UX If something is not proper tell me

@arpit456jain
Copy link
Owner

@Raj100 add bootstrap because that framework takes care of responsiveness , rest all is fine

@Raj100 Raj100 mentioned this issue Oct 16, 2023
5 tasks
@Raj100
Copy link
Contributor Author

Raj100 commented Oct 16, 2023

Thank You!😊It was my first open source contribution
Enjoyed contributing🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants