warnings fix #308
Open
warnings fix #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armink
reviewed
Aug 25, 2024
| @@ -1076,7 +1076,7 @@ static uint32_t new_kv(fdb_kvdb_t db, kv_sec_info_t sector, size_t kv_size) | |||
| already_gc = true; | |||
| goto __retry; | |||
| } else if (already_gc) { | |||
| FDB_INFO("Error: Alloc an KV (size %" PRIuLEAST16 ") failed after GC. KV full.\n", kv_size); | |||
| FDB_INFO("Error: Alloc an KV (size %" PRIuPTR ") failed after GC. KV full.\n", (uintptr_t)kv_size); | |||
There was a problem hiding this comment.
The size type is not suitable for outputting in pointer format. Is there any other way?
armink
requested changes
Sep 8, 2024
| @@ -1505,8 +1505,8 @@ void fdb_kv_print(fdb_kvdb_t db) | |||
| kv_iterator(db, &kv, &using_size, db, print_kv_cb); | |||
|
|
|||
| FDB_PRINT("\nmode: next generation\n"); | |||
| FDB_PRINT("size: %" PRIu32 "/%" PRIu32 " bytes.\n", (uint32_t)using_size + ((SECTOR_NUM - FDB_GC_EMPTY_SEC_THRESHOLD) * SECTOR_HDR_DATA_SIZE), | |||
| db_max_size(db) - db_sec_size(db) * FDB_GC_EMPTY_SEC_THRESHOLD); | |||
| FDB_PRINT("size: %lu/%lu bytes.\n", (unsigned long)((uint32_t)using_size + ((SECTOR_NUM - FDB_GC_EMPTY_SEC_THRESHOLD) * SECTOR_HDR_DATA_SIZE)), | |||
There was a problem hiding this comment.
Suggested change
| FDB_PRINT("size: %lu/%lu bytes.\n", (unsigned long)((uint32_t)using_size + ((SECTOR_NUM - FDB_GC_EMPTY_SEC_THRESHOLD) * SECTOR_HDR_DATA_SIZE)), | |
| FDB_PRINT("size: %" PRIu32 "/%" PRIu32 " bytes.\n", (uint32_t)(using_size + ((SECTOR_NUM - FDB_GC_EMPTY_SEC_THRESHOLD) * SECTOR_HDR_DATA_SIZE)), |
Is it possible to modify it like this?
| FDB_PRINT("size: %" PRIu32 "/%" PRIu32 " bytes.\n", (uint32_t)using_size + ((SECTOR_NUM - FDB_GC_EMPTY_SEC_THRESHOLD) * SECTOR_HDR_DATA_SIZE), | ||
| db_max_size(db) - db_sec_size(db) * FDB_GC_EMPTY_SEC_THRESHOLD); | ||
| FDB_PRINT("size: %lu/%lu bytes.\n", (unsigned long)((uint32_t)using_size + ((SECTOR_NUM - FDB_GC_EMPTY_SEC_THRESHOLD) * SECTOR_HDR_DATA_SIZE)), | ||
| (unsigned long)db_max_size(db) - (unsigned long)db_sec_size(db) * FDB_GC_EMPTY_SEC_THRESHOLD); |
There was a problem hiding this comment.
Suggested change
| (unsigned long)db_max_size(db) - (unsigned long)db_sec_size(db) * FDB_GC_EMPTY_SEC_THRESHOLD); | |
| (uint32_t)(db_max_size(db) - db_sec_size(db) * FDB_GC_EMPTY_SEC_THRESHOLD)); |
| @@ -1076,7 +1076,7 @@ static uint32_t new_kv(fdb_kvdb_t db, kv_sec_info_t sector, size_t kv_size) | |||
| already_gc = true; | |||
| goto __retry; | |||
| } else if (already_gc) { | |||
| FDB_INFO("Error: Alloc an KV (size %" PRIuLEAST16 ") failed after GC. KV full.\n", kv_size); | |||
| FDB_INFO("Error: Alloc an KV (size %" PRIuPTR ") failed after GC. KV full.\n", (uintptr_t)kv_size); | |||
There was a problem hiding this comment.
Suggested change
| FDB_INFO("Error: Alloc an KV (size %" PRIuPTR ") failed after GC. KV full.\n", (uintptr_t)kv_size); | |
| FDB_INFO("Error: Alloc an KV (size %" PRIu32 ") failed after GC. KV full.\n", (uint32_t)kv_size); |
Is it possible to modify it like this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning pulled from compiler fixed
OS tested:
RHEL 8,RHEL 9This branch contains some changes to original code to cast trought forgot variation of data types moved from a function to another, look up changes to understand my edit.
statusstruct has been initialized to {0, 0} to prevent errors, if any errors occurs while using it, the final code result on DB should not be affected.also
FDB_PRINT()has been modified to match the required data types as args on different calls.