Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: bluetooth: add support for RTL8852BE #111

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

Joshua-Riek
Copy link
Collaborator

@Joshua-Riek Joshua-Riek commented Oct 24, 2023

This PR fixes Bluetooth for the RTL8852BE, tested with the Orange Pi 5 Plus WiFi + Bluetooth module.

Cherry-picked from: orangepi-xunlong/linux-orangepi@7e6c316
Firmware PR: armbian/firmware#67

amazingfate
amazingfate previously approved these changes Oct 25, 2023
@amazingfate
Copy link
Collaborator

mainline's commit to support RTL8852B: torvalds/linux@18e8055
Is it possiable to use the firmware from mainline?

@amazingfate amazingfate dismissed their stale review October 25, 2023 07:22

It has to overwrite mainline firmware file, need to reconsider.

@rpardini
Copy link
Member

True. We've had similar during rtw88 migration on mainline, I think with 8822CS SDIO; the old driver matches with old firmware, while the mainline needs newer firmware.
In this case, a viable hack would be to rename prefix rtl_bt/rtl8852bu to rtl_bt/rtl8852bu_vendor (or some such) in both the kernel source and fw filenames?

@Joshua-Riek
Copy link
Collaborator Author

I will test out the mainline firmware tonight and see if it can work. If the vendor firmware is required, I think adding a vendor prefix will be a good alternative.

@Joshua-Riek
Copy link
Collaborator Author

Joshua-Riek commented Oct 25, 2023

I just confirmed we can use the firmware from mainline. So, this should be good to merge. I will close armbian/firmware#67.

Thanks!

@Joshua-Riek
Copy link
Collaborator Author

I think that I misunderstood. Should I send a PR to the firmware repo with the latest mainline RTL8852BE firmware?

@amazingfate
Copy link
Collaborator

No need to add mainline firmware to armbian/firmware, armbian-firmware-full will package the latest mainline firmware.

@Joshua-Riek Joshua-Riek merged commit 0d05f8c into armbian:rk-5.10-rkr6 Oct 27, 2023
2 checks passed
@Joshua-Riek Joshua-Riek deleted the opi5plus-bt branch November 12, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants