Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gemini] update deps and resolve small compile errors #11

Open
z-tech opened this issue Oct 4, 2023 · 2 comments
Open

[Gemini] update deps and resolve small compile errors #11

z-tech opened this issue Oct 4, 2023 · 2 comments

Comments

@z-tech
Copy link

z-tech commented Oct 4, 2023

Synopsis:

First I noticed gemini -> main compile fails:

error: failed to load source for dependency `ark-ec`

Caused by:
  Unable to update https://github.com/mmaker/algebra?branch=feature/additive-groups#1419b95a

Then I noticed the PR merged on May 10, 2023 arkworks-rs/algebra <- feature/additive-groups

I updated cargo.toml to point to arkworks-rs/algebra -> main and resolved some tiny type errors like these:

fn advance_by(&mut self, n: usize) -> Result<(), usize> {
                                            ^^^^^^^^^^^^^^^^^
                                            expected `core::num::NonZeroUsize`, found `usize`
                                            help: change the output type to match the trait: `core::result::Result<(), core::num::NonZeroUsize>`

Result:

  • no compile errors for cargo test, cargo rustdoc --open, cargo run --features asm,print-trace,parallel --example snark -- -i 4
  • tests pass, benches work
@z-tech z-tech converted this from a draft issue Oct 4, 2023
@z-tech z-tech moved this to In Progress in Repo organization and CI Oct 4, 2023
@mmaker
Copy link
Member

mmaker commented Oct 11, 2023

Hello! thank you so much, indeed part of the work here was based on PR's that are now merged in arkworks. I think we can update them once ark-group exists. What do you think?

I think the remaining issues are only minor rust updates.

@z-tech
Copy link
Author

z-tech commented Nov 13, 2023

Sorry for the delay. This of course sounds good to me 😛

@z-tech z-tech moved this from In Progress to Todo in Repo organization and CI Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants