-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server stopping for each update #678
Comments
What is logged in |
last lines of arserver
last line of arkmanager.log I guess it s more a problem because of the game than your tools but still it's annoying |
It looks like you're running 2 servers from the same directory. One server is being updated, while the other is being restarted some time later. Additionally, it looks like the |
I have been having this same issue, and my logs contain roughly the same output. I am only running one instance, however there are two things I notice that are consistent:
I normally see I have updates configured in a cron job with the command |
I think both myself and @boistordu are running Ark in Docker using https://github.com/TuRz4m/Ark-docker from @TuRz4m. I think it is more specific to the image. So retract my statement. In the restart, some settings are correct, like the mods, but all the ones that are wrong like the Port, QueryPort, map, and such are all settings that are populated by environment variables. The main user controlled arkmanger.cfg has this:
And the
So I'll take a look at adjusting the crontab to properly have the environment variables as well. |
Ok... it seems I am chasing behind @boistordu again, he already filed an issue with the Docker image. 😄 But in the discussion, they didn't seem to reach the conclusion it was environment related with the crontab. |
ow no you are not chasing after me. I'm trying different tests from time to time but I need to come with the idea first, that's what takes time. |
The docker image pins arkmanager to v1.5 I suspect that ENV lines only apply to lines executed from the Dockerfile. cron would use whatever environment was inherited from the init system (systemd in this case). If the docker file writes the environment to a file that is sourced by the shell, then it might be best to |
yeah but i've changet that a long time ago by compiling myself. Sorry but I still don't see which line of env in the dockerfile or the rest that could indicate to cron to use different pid than the actual process of arkmanager launching ark. But I will continue to revise the code and do some tests. |
The PID isn't the actual problem. It starts the new server with completely wrong parameters, such as using TheIsland instead of TheCenter. The PID doesn't matter since way before that is where it was wrong. |
yes but then do we speak about PID problem and that there is actually 2 PID referenced in our logs. The system can't guess a PID to my knowledge, do it? And yes the start is with wrong parameters, totally agreeing with you on that but normally it shouldn't be a problem since we are changing that afterwards so shouldn't the process manager following that? ? plus normally the process managing all that is reading configurations files which precises another configuration than the first parameters no? |
What I mean, is that norammly no coders would (didn't revise the code of arkmanager) base the configruation of his tool on environment var if there are local configuration files. |
I agree, the issue is definitely the docker image. I was going to update it to have the crontab load the right environment variables. |
I think we need to take a beat here and discuss that more. |
maybe it would be best if both of us put in clear in the cfg files all the parameters. Like that we'll see if there is any change about that. |
My goal is to change the image to work without having to do more manual setup. Will try to have a PR for the docker image tomorrow. |
and what is your definition of manual setup here? we only need to define some of the parameters .... We'll see your code then but the first thing that came wrong with turzam was precisely that he didn't have the time to talk about the problems in his docker image. Anyway tell me when you have time to talk about it since I'm not comfortable for another one who again have no time to talk about the changes. |
Are you saying insinuating I am the other one who doesn't have time to talk about it? I'll have a PR for it. In my opinion, it is easier to have comments on something concrete as opposed to something half done. To your question though, should have it fixed by just stopping your Docker container, pulling the new image, an then running it with that image. That way it is just fixed for anyone already using the image and isn't a breaking change. |
no I wasn't saying that, I just don't wan't another Turzam case, that's what I'm saying. and you didn't seem to have understood a word of what I've said earlier. Like I said earlier, I've tested by removing env var and put the parameters in the *.cfg files directly => it hasn't change a thing, still same problem, still same logs content. And that was 3 or 4 months ago. So we can try again if you want to do that but did you at least test it already before to put in place another file ? |
Did you also hard set ark_Port and ark_QueryPort in /ark/arkmanager.cfg? These ones only existed in the docker image itself and wouldn't persist between container restarts. I was going to start a second server with an hourly server restart in cron to see if it has the same issue. Easier than waiting for the next update. |
yes I've done that too. But please test on your end too, maybe i've done something wrong at that time, it's totally possible that I've done slightly mistake or something else, so please try it too. Maybe I don't have enough knowledge to do so, but in any case I still don't see the link that you see between env var, crontab. So if it works at your end, I will be very happy to know I just didn't have the knowledge of what's happening here. |
What is the output of With the crontab env var issue, you will likely need to export the variables to a file and have |
docker exec ark arkmanager --version I know that certainly not the last commit but i didn't done an upgrade since 3 or 4 months ago. Since the change of using root or a specific user for arkmanager actually. |
actually I just think about something... you've changed from root to the user steam to run arkmanager correct? |
/etc/arkmanager/arkmanager.cfg doesn't get the right configuration settings in our dockerfile @kroberston |
@krobertson so anyway if you could enlight me about a problem that would be great. Why our docker container is the only one where copy the content of a env var in a *.cfg file is problematic? |
and by the way the ark port and ark query port are not up to date anymore with the new config file from arkamanger 1.6.14 |
Posted my changes here: TuRz4m/Ark-docker#17 From using it locally with a crontab that just did a restart, it appears to be working just fine. No other changes necessary to my existing crontab or config files. I pushed the image as |
i will continue to discuss of some specs to your changes on the comment of your modification |
Hi,
It seems that the server is stopping for each update and doesn't re run after or at least is not listening anymore so I need to restart it every time... Or maybe it's a port problem I don't kno ...
The text was updated successfully, but these errors were encountered: