Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataObject Support? #36

Open
purplespider opened this issue Nov 1, 2017 · 2 comments
Open

DataObject Support? #36

purplespider opened this issue Nov 1, 2017 · 2 comments

Comments

@purplespider
Copy link

Does the module support triggering a purge on the saving on DataObjects? Or just Pages?

e.g. When a new Testimonial DO is added, the related Testimonials Page should be purged.
Would also be good to be able to define which other pages/URLs need purging when a Page is edited. e.g. Also purge the Home page when a new News Article page is added (as the Home page lists latest news).

@zanderwar
Copy link
Contributor

zanderwar commented Nov 1, 2017

It currently only supports Pages. I do see your use case however not all DO's have a relation to a specific page, nor can I see any way of determining what pages they do belong to without that extra static you refer to.

If you have something in mind I would love to see a PR?

@purplespider
Copy link
Author

Yeh, it wouldn't be able to automatically detect which other pages/URLs should be purged, but should provide a way to easily specify the details. Was thinking something along the lines of Static Publisher's pagesAffectedByChanges() method.

I'll certainly have a look at implementing this, it may be a little beyond me though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants