Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated use of SAM lead to slowdown #706

Open
arjunrajlab opened this issue Jun 11, 2024 · 4 comments
Open

Repeated use of SAM lead to slowdown #706

arjunrajlab opened this issue Jun 11, 2024 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@arjunrajlab
Copy link
Collaborator

arjunrajlab commented Jun 11, 2024

Someone from lab noticed that while using SAM, the page starts to become slower and slower. At some point it may even crash. A page refresh seems to solve the issue. The issue seems to arise the longer you use SAM. We aren't sure if the issue is from the use of SAM specifically or just adding a large number of annotations one by one, but it has definitely show up with SAM. The issue is there whether you turn the SAM tool on and off or not, so it's probably not the encoder or anything like that.

Seems to occur once 100 annotations or so have been added/30 minutes of use.

@arjunrajlab arjunrajlab added the bug Something isn't working label Jun 11, 2024
@arjunrajlab arjunrajlab added this to the Alpha-Version milestone Jun 11, 2024
@arjunrajlab arjunrajlab moved this to Selected for development in Alpha Release Jun 11, 2024
@bruyeret
Copy link
Contributor

I created around 120 annotations with the SAM tool on the same page but I didn't notice anything
I have some questions:

  • Do the annotations have a big number of vertices (for example with simplification at 0)
  • Does the user encode a lot (I encoded less than 10 times to create the annotations)
  • Does it work with just manual blobs

Also is it "~100 annotations and 30 minutes" or "~100 annotations or 30 minutes"?

@bruyeret
Copy link
Contributor

Is it easy to reproduce ? If so, can the user share what happens in the console ?

@arjunrajlab
Copy link
Collaborator Author

I think it was ~100 annotations AND 30 minutes or so. I think it was a lot of vertices, but probably not simplification of zero. I think there was probably a lot of encoding and moving around the screen, but I will check. I'm not sure about manual blobs. I'll ask him to reproduce and show me the console!

@arjunrajlab
Copy link
Collaborator Author

From someone in lab:
"I am using simplification at 0, I am definitely encoding more than 10 times to create that number of annotations (probably more in the realm of 30 times), and it's 100 annotations in about 30 minutes. Worth noting as well that I'm switching rapidly between times while making the annotations to watch the colonies forming, I feel like that could be a part of it."

@arjunrajlab arjunrajlab moved this from Selected for development to Backlog in Alpha Release Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants