fix: throw a descriptive error when an undefined attribute is used for a... #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,7 +87,9 @@ exports.$CptComponent = { | |||
| for (var i = 0, sz = this.atts.length; sz > i; i++) { | |||
| att = atts[i]; | |||
| nm = att.name; | |||
| if (this.ctlAttributes[nm].type!=="template") { | |||
| if (!this.ctlAttributes || !this.ctlAttributes[nm]) { | |||
| throw new Error('The attribute "' + nm + '" was used but the component doesn\'t define this attribute.'); | |||
There was a problem hiding this comment.
The impacted component name is in this.info, so to be in line with other error messages, this one could be changed to:
throw new Error(this.info + ' The attribute "' + etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... component
Fixes #253
I'm afraid that this is the best I can think of doing based on what I can see being available in the context where the error occurs. Obviously we can't provide the original line number:column as a template is compiled but what is kind of not nice is the fact that we can't (?) provide the impacted component name as it is a function and its constructor seems to be an anonymous function...
@b-laporte, are there any other sources of data that I'm not aware of and we could use for better error reporting?