Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inputs.parameters not exist in ARGO_TEMPLATE env var #14075

Open
3 of 4 tasks
Oscourse1245 opened this issue Jan 13, 2025 · 9 comments
Open
3 of 4 tasks

inputs.parameters not exist in ARGO_TEMPLATE env var #14075

Oscourse1245 opened this issue Jan 13, 2025 · 9 comments
Labels
type/support User support issue - likely not a bug

Comments

@Oscourse1245
Copy link

Pre-requisites

  • I have double-checked my configuration
  • I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
  • I have searched existing issues and could not find a match for this bug
  • I'd like to contribute the fix myself (see contributing guide)

What happened? What did you expect to happen?

when upgrading from 3.5.8 to v3.6.0, I saw that in the ARGO_TRMPLATE env var, the inputs.parametes is missing.

Version(s)

v3.6.0

Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

any workflow

Logs from the workflow controller

I have private info in the controller log

Logs from in your workflow's wait container

same as above
@Oscourse1245 Oscourse1245 added type/bug type/regression Regression from previous behavior (a specific type of bug) labels Jan 13, 2025
@jswxstw
Copy link
Member

jswxstw commented Jan 13, 2025

It is by design, please see the ChangeLog:

@jswxstw jswxstw added type/support User support issue - likely not a bug and removed type/bug type/regression Regression from previous behavior (a specific type of bug) labels Jan 13, 2025
@Oscourse1245
Copy link
Author

I see, but the env var ARGO_TEMPLATE_WITH_INPUTS_PARAMETERS is removed and I don't have the ability to add the inputs.parameters by the controller configuration.
Am I wrong?

@jswxstw
Copy link
Member

jswxstw commented Jan 13, 2025

I see, but the env var ARGO_TEMPLATE_WITH_INPUTS_PARAMETERS is removed and I don't have the ability to add the inputs.parameters by the controller configuration.

ARGO_TEMPLATE_WITH_INPUTS_PARAMETERS is removed in #13761, which is based on this consideration: #13761 (comment)

@Oscourse1245
Copy link
Author

Can I configure the controller to add the inputs.parameters to ARGO_TEMPLATE env var?

@jswxstw
Copy link
Member

jswxstw commented Jan 13, 2025

Sorry, but this is no longer supported. By the way, may I ask why you are relying on inputs.parameters in ARGO_TEMPLATE?

@Oscourse1245
Copy link
Author

Oscourse1245 commented Jan 13, 2025

we are using the any parameters after they resolved, the ARGO_TEMPLATE contain them, we are resubmitting the specific template after some adjustment.
do you think we can get the resolved parameters in other way?

@jswxstw
Copy link
Member

jswxstw commented Jan 13, 2025

Shouldn't the parameters be passed to the container args?

@Oscourse1245
Copy link
Author

Yes, I am getting the parameters, but I asked for better way to resolve it, instead of parse any parameter one by one.

@jswxstw
Copy link
Member

jswxstw commented Jan 14, 2025

Variable inputs.parameters contains all input parameters to a template as a JSON string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/support User support issue - likely not a bug
Projects
None yet
Development

No branches or pull requests

2 participants