Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shorter version of channel_flow test #290

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

nglaser3
Copy link
Contributor

Summary of changes

This PR adds a shorter, non-heavy, version of the channel_flow test. The run time of this shorter version is approximately 20 seconds. This is desired as some of the components being tested in this file were only being tested in heavy tests, causing test failures to slip under the radar.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Required for Merging

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
    • CI tests pass
    • Local tests pass (including Serpent2 integration tests)

Associated Developers

Checklist for Reviewers

Reviewers should use this link to get to the
Review Checklist before they begin their review.

@smpark7
Copy link
Collaborator

smpark7 commented Oct 11, 2024

I wonder if we can avoid creating a new input file by using the original channel-flow.i file and adding cli_args = "Executioner/num_steps=5" in the tests file. I'm not sure whether exodiff takes issue with having an input file for two exodiff tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants