Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor external dependencies to be always encapsulated #31

Open
3 tasks
areknoster opened this issue Feb 6, 2022 · 0 comments
Open
3 tasks

Refactor external dependencies to be always encapsulated #31

areknoster opened this issue Feb 6, 2022 · 0 comments
Assignees
@areknoster
Labels
refactor

Comments

@areknoster
Copy link
Owner

Currently some dependencies seem to be spread across PDCL components - e.g. FirstToLastConsumer is coupled with IPNS. Instead, those kind of dependencies should be designed as logical unit, that's hidden behind an interface and can have multiple implementations.

In particular following changes could be introduced:

  • IPNS should implement thead interfaces and no component should depend on it directly
  • ratelimiting should be a part of grpc package
  • CID should be agnostic to IPFS implementation

Worth discussing: should proto be somehow abstracted away?
@areknoster areknoster self-assigned this Feb 6, 2022
@areknoster areknoster changed the title Refactor external dependencies to be always encapsulated in some implementation Refactor external dependencies to be always encapsulated Feb 6, 2022
areknoster added a commit that referenced this issue Feb 6, 2022
@areknoster
refactor(thead): refactor ipns logic to implement thead. #31
11a88a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@areknoster areknoster

Labels
refactor
Projects
Public Distributed Commit Log
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@areknoster