Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The trigger mode selection should be sent to the device immediately when changed #5

Open
MarkRivers opened this issue Sep 9, 2018 · 0 comments
Assignees

Comments

@MarkRivers
Copy link
Member

Currently the trigger mode selection is only sent to the device (SDK call) when acquisition is started. This is not good because switching triggers modes can enable detector scrubbing. If scrubbing is currently disabled and then a trigger mode that enables scrubbing is selected we want the scrubbing to be enabled immediately, not when acquisition is started. If not then the first images may have excess dark current.

The fix is quite easy. The SDK calls at the beginning of the start acquisition function should be moved to a new setupAcquisition function that is called from the writeInt32 or writeFloat64 function when any of the relevant parameters are changed.

@MarkRivers MarkRivers self-assigned this Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant