Fix attribute datatypes in TIFF plugin #520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
A new attribute XML file was added to simDetector to generate an instance of each attribute numeric datatype.
https://github.com/areaDetector/ADSimDetector/blob/master/iocs/simDetectorIOC/iocBoot/iocSimDetector/testAttributeDataTypes.xml
I tested ADSimDetector using that XML file.
I printed out the values of the NDArray attributes:
The numeric attributes with names like Int8, UInt8, ... Float64 all have the correct data types and values.
I then saved a TIFF file, and ran tiffinfo on it:
The values of all the numeric attribute datatypes are correct.