Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dimmer.ino #70

Closed
wants to merge 6 commits into from
Closed

Update Dimmer.ino #70

wants to merge 6 commits into from

Conversation

mhmdaliab
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 29, 2023

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 linked an issue Dec 30, 2023 that may be closed by this pull request
3 tasks
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to submit a pull request @mhmdaliab.

As explained in the comment at the top of the example, and in the associated tutorial, this sketch is not intended to be used with a serial terminal, but instead with the provided Processing or Max programs that run on the PC.

The example is specifically configured to consume the format of the serial data that is sent by the Processing and Max programs, so the changes you propose here would actually break the example and thus can not be accepted.

You are welcome to publish this modified sketch yourself for the benefit of Arduino community members who want to control an LED from the Serial Monitor. You can use a GitHub repository for that, or perhaps the Arduino Project Hub.

@per1234 per1234 self-assigned this Dec 30, 2023
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Dec 30, 2023
@per1234 per1234 closed this Dec 30, 2023
@per1234 per1234 added the conclusion: invalid Issue/PR not valid label Dec 30, 2023
@per1234 per1234 mentioned this pull request Dec 30, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dimmer.ino does not work
3 participants