Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE.scan will not work after a BLE.scanFor[Uuid|Name|Address], even after a BLE.stopScan #350

Open
andrewchilds opened this issue Feb 2, 2024 · 0 comments · May be fixed by #351
Open
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@andrewchilds
Copy link

andrewchilds commented Feb 2, 2024

Hello! Thank you for building and maintaining this library. Here is a simple test case with a buggy path, and a separate workaround using the existing library code:

#include <ArduinoBLE.h>

#define SERVICE_UUID "MY-SERVICE-UUID"

unsigned long scanStart;
bool fallbackToFullScan = false;

void setup() {
  Serial.begin(9600);
  delay(1000); // Wait for serial

  if (!BLE.begin()) {
    Serial.println("Starting BLE failed!");
    while (1);
  }

  Serial.println("Scanning by Service UUID...");
  BLE.scanForUuid(SERVICE_UUID);
  scanStart = millis();
}

void notWorkingScan() {
  BLE.stopScan();
  delay(1000);
  // This scan will not work - it will continue to behave like BLE.scanForUuid(SERVICE_UUID)
  BLE.scan();
}

void workingScan() {
  // This will reset _scanNameFilter, _scanUuidFilter, and _scanAddressFilter to ""
  BLE.scanForUuid("");
  BLE.stopScan();
  delay(1000);
  // This scan will now work
  BLE.scan();
}

void loop() {
  BLEDevice peripheral = BLE.available();

  if (peripheral) {
    Serial.println("Peripheral found!");
    BLE.stopScan();
  }

  // Wait 5 seconds to connect, then fall back to a regular scan.
  if (!fallbackToFullScan && millis() - scanStart > 5000) {
    scanStart = millis();
    Serial.println("Falling back to full scan...");
    fallbackToFullScan = true;
    // notWorkingScan();
    workingScan();
  }
}

From looking at GAP.cpp, it seems that _scanNameFilter, _scanUuidFilter, and _scanAddressFilter are not unset during a stopScan, so a BLE.scan will continue to use the previous filters (since BLE.available is where the filters are used). You can unset the filters by passing an empty string to scanForUuid(), scanForName(), or scanForAddress(), at which point the subsequent BLE.scan will start working.

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Feb 2, 2024
andrewchilds added a commit to andrewchilds/ArduinoBLE that referenced this issue Feb 5, 2024
@per1234 per1234 linked a pull request Feb 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants