Buffer overflow with Giga R1 WiFi

[controllercustom]

On Giga R1 WiFi with Murata 1DX Bluetooth 5.1, the ATT error response PDU is 5 bytes (see Bluetooth Core v5.1, section 3.4.1.1) but the response buffer is only 4 bytes long. respLength is 5.

• BLERemoteDescriptor::writeValue
  

  ArduinoBLE/src/remote/BLERemoteDescriptor.cpp

  Line 79 in 8ca5415

  uint8_t resp[4];

• BLERemoteCharacteristic::writeValue
  

  ArduinoBLE/src/remote/BLERemoteCharacteristic.cpp

  Line 109 in 8ca5415

  uint8_t resp[4];

A buffer size of 256 avoids the buffer overflow but might be overkill.

However, fixing this still does not fix any problems with subscribing/reading characteristics on some devices. But at least the failure code in the PDU does point to insufficent authentication (error code 0x05). So perhaps the peripheral is not satisfied with pairing/bonding.

Testing is done using PeripheralExplorer.