Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuntimeError: 'weight' must be 2-D #3

Open
Hasan-Syed25 opened this issue Aug 7, 2024 · 6 comments
Open

RuntimeError: 'weight' must be 2-D #3

Hasan-Syed25 opened this issue Aug 7, 2024 · 6 comments

Comments

@Hasan-Syed25
Copy link

RuntimeError: 'weight' must be 2-D occurs when I am using Deepspeed Zero3 for distributed training. Is this an issue with deepspeed or is it an initialization issue. Here is link to the same issue that I am facing. What am I missing here?

Thanks

@Crystalcareai
Copy link
Collaborator

Deepspeed zero3 currently throws a lot of errors - we're working on it and will have a fix out soon.

@fernando-neto-ai
Copy link
Contributor

@Hasan-Syed25 could you paste your env and your code, so I can deep dive on it?

@zhangchushu
Copy link

Same problem happens to me. Has anyone solved it?

@shing100
Copy link

Same problem happens to me. Has anyone solved this problem?

@raghavgarg97
Copy link

raghavgarg97 commented Oct 28, 2024

I would like to add a +1 too

I guess its probably because deepspeed is wrapping the student model but not the teacher model

A quick fix could be to store the logits offline.

@mertege
Copy link

mertege commented Nov 5, 2024

Deepspeed zero3 currently throws a lot of errors - we're working on it and will have a fix out soon.

FSDP also brings the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants