[FIX] Update the version of dcm2niix required to run clinica converters #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasGensollen
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
I agree, especially since the users should get a warning if they use a version of dcm2niix older than 1.0.20240202:
clinica/clinica/utils/check_dependency.py
Lines 459 to 460 in 4d700d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following users issues and some tests, it seems the version of dcm2niix can cause trouble when converting some images. We should recommend a more recent version of dcm2niix in our documentation. WDYT @NicolasGensollen ?