-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bottom of the page hidden on iOS #747
Comments
Can I work on this issue ? |
@Yannis182del Yes! Thank you 🙏 |
Here's the updated URL of implementation @Yannis182del ;) https://github.com/pakokrew/mooni/blob/master/app/src/components/ScrollRoot.jsx |
@Yannis182del the problem is coming from the ScrollView component in this aragon-ui repo https://github.com/aragon/aragon-ui/blob/master/src/components/ScrollView/ScrollView.js |
Thanks @pakokrew! I start to work on this |
Hi, @pakokrew @etherean06 is this issue still open? |
Hi, just tried again on Aragon client, and the bug is still present on Safari iOS. Here's an updated link to my workaround: Do you want me to reupload the video showing the bug ? |
hey @pakokrew, yes, please. |
@eliobricenov there you are. Only happens on Safari iOS, not firefox. replay_2.mp4replay_1.mp4 |
@pakokrew Thank you, that's helpful. |
I will hold working on this since I currently don't have a safari environment I can test on. |
Hey all, just started building a project on Aragon UI and was wondering if there was any updates on this, as it's still an issue... |
@giaset are you facing the same issue? If so, feel free to create a PR with the fix so the team can review it |
There's a recurring issue on iOS browser, where the viewport size is fixed, whatever if the URL or action bar is displayed or not.
This result having
100vh
usually larger that the actual screen, and not being able to scroll to the end of the page correctly.Here is a video showing the bug: https://streamable.com/2yguzw
Found this https://css-tricks.com/the-trick-to-viewport-units-on-mobile/ showing a work around, and implemented it in https://github.com/pakokrew/mooni/blob/develop/src/components/ScrollRoot.jsx, which looks like it solves pretty well the issue
The text was updated successfully, but these errors were encountered: