Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shared: TemplatesDeployer should not assume template constructor params #170

Open
sohkai opened this issue Dec 30, 2019 · 0 comments
Open

shared: TemplatesDeployer should not assume template constructor params #170

sohkai opened this issue Dec 30, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@sohkai
Copy link
Contributor

sohkai commented Dec 30, 2019

The TemplatesDeployer currently hardcodes four parameters as the constructor parameters to each template.

We should loosen this to allow a user to describe their templates' own constructor parameters. For contracts that we deploy, like the test ENS and aragonID, we can export symbols and check for them.
@sohkai sohkai added the enhancement New feature or request label Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sohkai