You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
this flag was not included by default, and something that can be optionally included with the existing tfsec_args functionality
OR there was a new action input parameter for --soft-fail that defaults to true, that you can override with false
Option 1 seems easier to implement but would likely be considered a "breaking change" and probably constitute a new major version release. I'm guessing option 2 would be more seamless, and something that could be introduced as a patch / minor version update.
The text was updated successfully, but these errors were encountered:
I'd even vote for "hard fail" by default.
Adding an if: success() || failure() to the upload-sarif task will make it run even when the check fails, so there's no need to short-circuit GitHub build failure mechanics.
This would be very helpful when designing workflows that work both with and without GH Advanced Security.
I'm hoping to optionally fail a status check when new tfsec alerts are found as part of a pull request workflow.
It appears the
--soft-fail
flag is hardcoded as an argument when this action runs the tfsec command: https://github.com/aquasecurity/tfsec-sarif-action/blob/master/entrypoint.sh#L55It would be great if:
tfsec_args
functionality--soft-fail
that defaults to true, that you can override with falseOption 1 seems easier to implement but would likely be considered a "breaking change" and probably constitute a new major version release. I'm guessing option 2 would be more seamless, and something that could be introduced as a patch / minor version update.
The text was updated successfully, but these errors were encountered: